[PATCH] cpufreq for freescale mx51

Sascha Hauer s.hauer at pengutronix.de
Thu Oct 7 03:50:12 EDT 2010


On Thu, Oct 07, 2010 at 10:40:44AM +0300, Amit Kucheria wrote:
> On 10 Oct 07, Yong Shen wrote:
> > 
> > > > +static struct cpufreq_frequency_table imx_freq_table[4];
> > >
> > > Three frequencies should be enough for everyone, right? This should be
> > > dynamically allocated like in other cpufreq drivers.
> > >
> > 
> > Yes, we only support 3 work points, which is for sure. Actually, we only
> > support 2 points on most mx51 chips. I supposed it is ok to use static array
> > here.
> 
> This can become a common cpufreq driver for all i.MX platforms. We don't know
> how many work points will be supported in future versions of the silicon.
> That is why a static array is not ok.
> 
> I think Sascha was being ironic when he said "Three frequencies should be
> enough for everyone, right?" :)

Yes, the old 640k-is-enough-for-anyone joke.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the linux-arm-kernel mailing list