[PATCH 1/3] ARM: imx: fix/define clocks and create devices for imx dma

Fabio Estevam fabioestevam at yahoo.com
Wed Oct 6 21:04:23 EDT 2010


Hi Uwe,

--- On Wed, 10/6/10, Uwe Kleine-König <u.kleine-koenig at pengutronix.de> wrote:

> +#if defined(CONFIG_ARCH_MX35)
> +    if (cpu_is_mx35())
> +        ret = imx_add_imx_sdma(&imx35_imx_sdma_data);
> +    else

Shouldn't you check the MX35 silicon version like you did for MX31?

If not checked this would fail for the old MX35 silicon. I understand that MX31 has mx31_revision() function, but there is no mx35_revision() currently.

Regards,

Fabio Estevam


      



More information about the linux-arm-kernel mailing list