[PATCH 1/2] ARM: S3C64XX: Add suspend support

[Kyungmin Park]

On Wed, Oct 6, 2010 at 8:27 AM, Maurus Cuelenaere <mcuelenaere at gmail.com> wrote:
>  Op 06-10-10 01:23, Kyungmin Park schreef:
>> Hi,
>>
>> I agree your approach, put the common features in common place.
>> but Samsung maintainers insist put these at each machine file at current time.
>>
>> So move this to the each machines for their tastes.
> I did it that way first, but then wondered why this wasn't done for all boards.
>
> When looking at some S3C24XX boards, you'll see that these need changes to the
> bootloader to support suspend; but IIRC this isn't needed for S3C64XX so I think
> this can be safely enabled for all S3C64XX boards?

There are be answered by Samsung maintainers.
I'm have same opinions since it's common feature. Previous time I
already argued with them but they reject it.
you can issue it again.

and current status.
# grep s3c_pm_init -H -R arch/arm/mach-*
arch/arm/mach-s3c2410/mach-qt2410.c:    s3c_pm_init();
arch/arm/mach-s3c2410/mach-h1940.c:     s3c_pm_init();
arch/arm/mach-s3c2412/mach-jive.c:      s3c_pm_init();
arch/arm/mach-s3c2440/mach-rx3715.c:    s3c_pm_init();
arch/arm/mach-s3c2440/mach-gta02.c:     s3c_pm_init();
arch/arm/mach-s3c2440/mach-rx1950.c:    s3c_pm_init();
arch/arm/mach-s5pv210/mach-smdkv210.c:  s3c_pm_init();
arch/arm/mach-s5pv210/mach-smdkc110.c:  s3c_pm_init();

Thank you,
Kyungmin Park

>
> --
> Maurus Cuelenaere
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>