[PATCH] ARM: Stop irqsoff tracing if return to user with interrupts enabled

Russell King - ARM Linux linux at arm.linux.org.uk
Sat Nov 13 04:38:39 EST 2010


On Sat, Nov 13, 2010 at 08:48:02AM +0000, Russell King - ARM Linux wrote:
> On Fri, Nov 12, 2010 at 07:40:48PM -0800, Todd Poynor wrote:
> > Signed-off-by: Todd Poynor <toddpoynor at google.com>
> 
> NAK.  Firstly, you're not explaining why.  Secondly, we purposely leave
> IRQs off when returning to userspace to avoid race conditions.  Thirdly,
> we purposely leave lockdep believing that IRQs are off while userspace
> is running, even though IRQs are not.

Forthly, we never run userspace with IRQs disabled - that would be a
security hole.

> I've explained why this is in the past - please search the mailing list.

See

http://lists.arm.linux.org.uk/lurker/message/20100523.141301.a94bee0c.en.html
http://lists.arm.linux.org.uk/lurker/message/20100523.194746.203225eb.en.html



More information about the linux-arm-kernel mailing list