[PATCH 1/3] OMAP: DSS2: Add dummy panel display driver

[Bryan Wu]

On Tue, Nov 2, 2010 at 1:21 PM, Grazvydas Ignotas <notasas at gmail.com> wrote:
> On Tue, Nov 2, 2010 at 6:13 PM, Bryan Wu <bryan.wu at canonical.com> wrote:
>> Dummy panel driver includes the driver and 4 similar panel configurations. It
>> will match the panel name which is passed from platform data and setup the
>> right configurations.
>>
>> With dummy panel driver, we can remove those 4 duplicated panel display
>> drivers. In the future, it is simple for us just add new panel configuration
>> date in panel-dummy.h to support new display panel.
>>
>> Signed-off-by: Bryan Wu <bryan.wu at canonical.com>
>
> <snip>
>
>> diff --git a/drivers/video/omap2/displays/panel-dummy.h b/drivers/video/omap2/displays/panel-dummy.h
>> new file mode 100644
>> index 0000000..ac2b7a2
>> --- /dev/null
>> +++ b/drivers/video/omap2/displays/panel-dummy.h
>
> There is no benefit of having this header, just add all data directly
> in .c file.
>
> <snip>
>
>> +       /* Sharp LQ043T1DG01 */
>> +       {
>> +               {       .x_res          = 480,
>> +                       .y_res          = 272,
>
> missing newline after {
>

Thanks, I will take these 2 comments.

-- 
Bryan Wu <bryan.wu at canonical.com>
Kernel Developer    +86.138-1617-6545 Mobile
Ubuntu Kernel Team
Canonical Ltd.      www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com