[PATCH] Voipac PXA270: UDC and UHC support

Eric Miao eric.y.miao at gmail.com
Sun Mar 21 21:57:33 EDT 2010


>> +static void vpac270_udc_command(int cmd)
>> +{
>> +     if (cmd == PXA2XX_UDC_CMD_CONNECT)
>> +             UP2OCR |= UP2OCR_HXOE | UP2OCR_DPPUE | UP2OCR_DPPUBE;
>> +     else if (cmd == PXA2XX_UDC_CMD_DISCONNECT)
>> +             UP2OCR &= ~(UP2OCR_HXOE | UP2OCR_DPPUE | UP2OCR_DPPUBE);
>
> In the "DISCONNECT" case, you reset UP2OCR_HXOE, meaning the usb port isn't a
> USB Device anymore (neither a USB host). If that's on purpose, then all good, in
> the other case, don't reset that one.
>

Marek??

> Otherwise, you can add for the UDC part :
> Reviewed-by: Robert Jarzmik <robert.jarzmik at free.fr>
>
> --
> Robert
>



More information about the linux-arm-kernel mailing list