[PATCH] ARM: Add ARCH_HAS_L2X0 and make CACHE_L2X0 config depend on that

Eric Miao eric.y.miao at gmail.com
Wed Jun 16 10:22:07 EDT 2010


On Wed, Jun 16, 2010 at 10:13 PM, Olof Johansson <olof at lixom.net> wrote:
> On Wed, Jun 16, 2010 at 11:43:29AM +0800, Eric Miao wrote:
>> On Mon, Jun 14, 2010 at 10:59 PM, Olof Johansson <olof at lixom.net> wrote:
>> > On Sun, Jun 13, 2010 at 06:16:26AM +0100, Ben Dooks wrote:
>> >> On Fri, Jun 11, 2010 at 10:58:07AM -0700, Daniel Walker wrote:
>> >> >
>> >> > I made a similar change not too long ago, but Russell wanted the define
>> >> > to be HAVE_CACHE_L2X0 ..
>> >>
>> >> possibly, I was thinking ARM_L2X0 would also be an option, since if I
>> >> remeber correctly it is selecting the driver not the availability of
>> >> it.
>> >
>> > Yeah, there are lots of different possible names. :)
>> >
>> > Let's just go with the one Russell preferred and not worry too much
>> > about it. There's some presendence to using HAVE_.* already.
>> >
>>
>> Sometimes I am thinking that maybe ARCH_HAS_* has some benefits:
>>
>> HAVE_* for those kernel-wide and general capabilities
>> ARCH_HAS_* for those ARM machine-class specific capabilities?
>>
>> So to make things a bit more clear? If ARCH_HAS_* is widely adopted
>> on architectures other than ARM, maybe we can then switch that name
>> to HAVE_*?
>
> We're nowhere near depleting the HAVE_.* namespace, it's quite sparsely
> used at the moment.

No I'm not talking about depleting the HAVE_* , just wondering if there is a way
to make things a bit clearer.

> I don't see a need to overengineer things here.
>
> A bike shed of any color will do, etc.
>

Agreed.



More information about the linux-arm-kernel mailing list