[PATCH 1/3] s3c64xx: Fix build without SDHCI controllers

Kukjin Kim kgene.kim at samsung.com
Thu Jun 10 23:58:46 EDT 2010


Kyungmin Park wrote:
> 
> On Fri, Jun 11, 2010 at 9:56 AM, Kukjin Kim <kgene.kim at samsung.com> wrote:
> > Marek Szyprowski wrote:
> >>
> >> This patch fixes the following compilation problem if only NCP machine
> >> is selected:
> >>
> >> arch/arm/mach-s3c64xx/s3c6410.c: In function ‘s3c6410_map_io’:
> >> arch/arm/mach-s3c64xx/s3c6410.c:51: error: implicit declaration of function
> >> ‘s3c6410_default_sdhci2’
> >>
> >> Signed-off-by: Marek Szyprowski <m.szyprowski at samsung.com>
> >> Signed-off-by: Kyungmin Park <kyungmin.park at samsung.com>
> >> ---
> >>  arch/arm/plat-samsung/include/plat/sdhci.h |    1 +
> >>  1 files changed, 1 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/arch/arm/plat-samsung/include/plat/sdhci.h b/arch/arm/plat-
> >> samsung/include/plat/sdhci.h
> >> index 13f9fb2..c2044e5 100644
> >> --- a/arch/arm/plat-samsung/include/plat/sdhci.h
> >> +++ b/arch/arm/plat-samsung/include/plat/sdhci.h
> >> @@ -166,6 +166,7 @@ static inline void s3c6410_default_sdhci2(void) { }
> >>  #else
> >>  static inline void s3c6410_default_sdhci0(void) { }
> >>  static inline void s3c6410_default_sdhci1(void) { }
> >> +static inline void s3c6410_default_sdhci2(void) { }
> >>  static inline void s3c6400_default_sdhci0(void) { }
> >>  static inline void s3c6400_default_sdhci1(void) { }
> >>
> >> --
> >
> > Maybe missed in Maurus' patch 'S3C64XX: add HSMMC2 support'
> > commit 92b118f6968ae0788ac659af47b464acd9a754a1
> 
> Which kernel tree do you use?
> it's against the latest kernel.
>
Of course, Linus' 35-rc2.
Any problem?

> >
> > Also need 'static inline s3c6400_default_sdhci2(void) { }'
> > Could you re-submit updated patch including s3c6400_default_sdhci2()?
> >


Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.




More information about the linux-arm-kernel mailing list