[PATCH 2/5] [ARM] Remove unused INITRD_PHYS from arch/arm/boot/compressed

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Thu Jun 10 04:27:17 EDT 2010


Hello,

On Thu, Jun 03, 2010 at 03:36:50PM +0800, Eric Miao wrote:
> From: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> 
> Original patch from Uwe Kleine-König <u.kleine-koenig at pengutronix.de>.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> Signed-off-by: Eric Miao <eric.miao at canonical.com>
The patch is OK, but the commit log of my patch was (IMHO) better.
Something like:

Only arch/arm/boot/bootp/init.S uses initrd_phys, so there is no need to
pass it in arch/arm/boot/compressed.

And I would prefer not to have this "Original patch from ..." in the
commit log.  Do you use it because the patch system doesn't offer to
specify the author of a commit?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



More information about the linux-arm-kernel mailing list