[PATCH]ARM/footbridge: fix wrong parenthesis

Russell King - ARM Linux linux at arm.linux.org.uk
Mon Jun 7 10:01:31 EDT 2010


On Fri, Jun 04, 2010 at 05:28:41PM +0800, Wan ZongShun wrote:
> There is a wrong redundant right parenthesis in this code.

This patch is wrong.

>  unsigned long __pfn_to_bus(unsigned long pfn)
>  {
> -	return __pfn_to_phys(pfn) + (fb_bus_sdram_offset() - PHYS_OFFSET));
> +	return __pfn_to_phys(pfn + (fb_bus_sdram_offset() - PHYS_OFFSET));

It makes no sense to add byte address offsets to a PFN.  The correct
solution is to delete the right paren at the end of the line instead.



More information about the linux-arm-kernel mailing list