[PATCH 1/2] ISL6271A voltage regulator support.

Mark Brown broonie at opensource.wolfsonmicro.com
Mon Jun 7 07:48:56 EDT 2010


On Mon, Jun 07, 2010 at 07:18:27AM +0200, Marek Vasut wrote:

> This device is very simple, it supports only one LDO. This single LDO is
> programmed over I2C to 16 possible voltages.

Marek, you really should know to CC patches to maintainers by now.  This
is not CCed to myself, Liam or lkml.

> +#include <linux/regulator/driver.h>
> +#include <linux/regulator/machine.h>

Why are you including machine.h here?  I can't actually see any suspect
code in the driver so I suspect it's unused.

Otherwise this looks good.



More information about the linux-arm-kernel mailing list