[PATCHv2 1/3] MTD/pxa: use __devinit for pxa2xx_flash_probe

Eric Miao eric.y.miao at gmail.com
Sun Jun 6 05:27:58 EDT 2010


On Sun, Jun 6, 2010 at 1:18 AM, Sergei Shtylyov <sshtylyov at mvista.com> wrote:
> Wan ZongShun wrote:
>
>> This patch is to use the '__devinit' for pxa2xx_flash_probe.
>
>   Why? Is it hot-pluggable device? I guess not...
>

Then I guess the __devexit is not applicable to pxa2xx_flash_remove as well.
Apart from the _probe() being unnecessarily built in when HOTPLUG is
defined, is there any drawbacks. It does make code a little bit consistent
from my POV.

>> Signed-off-by: Wan ZongShun <mcuos.com at gmail.com>
>> Acked-by: Eric Miao <eric.y.miao at gmail.com>
>
> WBR, Sergei
>
>



More information about the linux-arm-kernel mailing list