[PATCH 5/6] arm/ns9xxx: fix debug macro compilation failure

Russell King - ARM Linux linux at arm.linux.org.uk
Thu Jul 22 06:38:34 EDT 2010


On Wed, Jul 14, 2010 at 10:32:39AM +0800, Jeremy Kerr wrote:
> We need mach/memory.h for NS9XXX_CSxSTAT_PHYS, and mach/memory.h needs
> asm/memory.h for UL().

NAK.  Definitely NAK.  You haven't checked what includes whatelse.

asm/memory.h includes mach/memory.h to pick up the platform specific
parts, and provides mach/memory.h with its pre-requisits.  Use asm/memory.h
_everywhere_ rather than mach/memory.h.

Doing otherwise will create include loops, which leads to unreliability
in defined symbols.



More information about the linux-arm-kernel mailing list