[PATCH 04/10 v2] v4l: Add Samsung FIMC (video postprocessor) driver

Sylwester Nawrocki s.nawrocki at samsung.com
Fri Jul 16 12:33:43 EDT 2010


> -----Original Message-----
> From: Kukjin Kim [mailto:kgene.kim at samsung.com]
> Sent: Friday, July 16, 2010 1:39 PM
> To: 'Sylwester Nawrocki'; linux-samsung-soc at vger.kernel.org; linux-arm-
> kernel at lists.infradead.org
> Cc: p.osciak at samsung.com; m.szyprowski at samsung.com;
> kyungmin.park at samsung.com; linux-media at vger.kernel.org
> Subject: RE: [PATCH 04/10 v2] v4l: Add Samsung FIMC (video
> postprocessor) driver
> 
> Sylwester Nawrocki wrote:
> >
> Hi,
> 
> Samsung S.LSI hardly recommends DMA mode to implement the feature not
> FIFO
> mode because of H/W limitation.

Does the hardware issue occur in all SoCs or only some specific versions 
are affected?
So far we were successful with S5PC110 EVT0, however we could not make 
it work on S5PV210 (EVT1). That said I have created an option in the FIMC
variant definition (samsung_fimc_variant::fifo_capable) so that 
the V4L2 video node for FIMC FIFO operation mode is registered only 
for selected SoC variants.

> 
> > This driver exports two video device nodes per each FIMC device,
> > one for for memory to memory (color conversion, image resizing,
> > flipping and rotation) operations and one for direct
> > V4L2 output interface to framebuffer.
> >
> > Signed-off-by: Sylwester Nawrocki <s.nawrocki at samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park at samsung.com>
> > Reviewed-by: Pawel Osciak <p.osciak at samsung.com>
> > Reviewed-by: Marek Szyprowski <m.szyprowski at samsung.com>
> > ---
> >  drivers/media/video/Kconfig                  |   20 +
> >  drivers/media/video/Makefile                 |    1 +
> >  drivers/media/video/samsung/fimc/Makefile    |    3 +
> >  drivers/media/video/samsung/fimc/fimc-core.c | 1664
> > ++++++++++++++++++++++++++
> >  drivers/media/video/samsung/fimc/fimc-core.h |  541 +++++++++
> >  drivers/media/video/samsung/fimc/fimc-fifo.c |  814 +++++++++++++
> >  drivers/media/video/samsung/fimc/fimc-reg.c  |  585 +++++++++
> >  include/linux/videodev2.h                    |    1 +
> >  8 files changed, 3629 insertions(+), 0 deletions(-)
> >  create mode 100644 drivers/media/video/samsung/fimc/Makefile
> >  create mode 100644 drivers/media/video/samsung/fimc/fimc-core.c
> >  create mode 100644 drivers/media/video/samsung/fimc/fimc-core.h
> >  create mode 100644 drivers/media/video/samsung/fimc/fimc-fifo.c
> >  create mode 100644 drivers/media/video/samsung/fimc/fimc-reg.c
> >
> 
> (snip)
> 
> Thanks.
> 
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.

Best regards,
--
Sylwester Nawrocki
Samsung Poland R&D Center





More information about the linux-arm-kernel mailing list