[PATCH] Support for Buffalo WXL (Terastation Duo)

Nicolas Pitre nico at fluxnic.net
Tue Feb 23 17:15:18 EST 2010


On Tue, 23 Feb 2010, Sebastien Requiem wrote:

> Hi everyone,
> 
> 
> 
> I have created a patch to support a new Sub architecture.
> 
> 
> Description of patch:
> 
> * Modification of Kconfig to add the Option
> * 1 new file : buffalo-wxl-setup.c
> This file is inspired from the db-78xx0-setup.c already present.
> The following is done:
>  - Configure MPP Lines for the plateform (see my patch for MPP)
> This is taken from the stock kernel provided by buffalotech (the vendor)
>  - GigaBit Ethernet
>  - Sata
>  - Uart are initiallized in a different way than on the dev board as we have
> one core only.
>  - USB
> 
> 
> The kernel has been running for some days now on my plateform.
> 
> I would appreciate if you had time to review my patch and give me any 
> comments/feedback regarding my work.

All previous comments also apply to this patch.

Furthermore you used the config symbol MACH_BUFFALO_WXL while the 
machine record expects MACH_TERASTATION_WXL.  And in wxl_pci_init() you 
used machine_is_db78x00_bp() instead of machine_is_terastation_wxl() 
which is actively wrong.

I've fixed up those and pushed the result too.


Nicolas



More information about the linux-arm-kernel mailing list