[RFC PATCH v2 2/2] ARM: VFP: preserve the HW context when calling signal handlers

Russell King - ARM Linux linux at arm.linux.org.uk
Sat Feb 6 04:25:44 EST 2010


On Thu, Feb 04, 2010 at 11:38:30PM +0200, Imre Deak wrote:
> diff --git a/arch/arm/include/asm/user.h b/arch/arm/include/asm/user.h
> index df95e05..ea7e44d 100644
> --- a/arch/arm/include/asm/user.h
> +++ b/arch/arm/include/asm/user.h
> @@ -88,6 +88,9 @@ struct user{
>  struct user_vfp {
>  	unsigned long long fpregs[32];
>  	unsigned long fpscr;
> +	unsigned long fpexc;
> +	unsigned long fpinst;
> +	unsigned long fpinst2;

Absolutely no way is this anywhere near suitable.  This is a _userspace_
_visible_ API change, breaking anyone using the ptrace API by overwriting
additional memory which they will not be expecting.



More information about the linux-arm-kernel mailing list