[PATCH] rtc: driver for the DryIce block found in i.MX25 chips

Lothar Waßmann LW at KARO-electronics.de
Mon Feb 1 03:08:37 EST 2010


Hi,

Just one nitpick, I didn't notice when replying to your first mail...
Baruch Siach writes:
[...]
> +static inline void di_int_enable(struct imxdi_dev *imxdi, u32 intr)
> +{
> +	unsigned long flags;
> +
> +	spin_lock_irqsave(&imxdi->irq_lock, flags);
> +	__raw_writel(__raw_readl(imxdi->ioaddr+DIER) | intr,
                                              ^
> +			imxdi->ioaddr+DIER);
                                     ^
>
Spaces around operators are welcome in the kernel.


Lothar Waßmann
-- 
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info at karo-electronics.de
___________________________________________________________



More information about the linux-arm-kernel mailing list