[PATCH v2 4/8] OMAP4: clock data: Add missing fields in iva_hsd_byp_clk_mux_ck

Cousson, Benoit b-cousson at ti.com
Mon Dec 13 08:14:10 EST 2010


Hi Paul,

On 12/11/2010 1:34 AM, Paul Walmsley wrote:
> On Thu, 9 Dec 2010, Benoit Cousson wrote:
>
>> From: Jonathan Bergsagel<jbergsagel at ti.com>
>>
>> Add register address, mask and link to the clksel structure that
>> were missing in the IVA DPLL mux clock node.
>>
>> Signed-off-by: Jonathan Bergsagel<jbergsagel at ti.com>
>> Signed-off-by: Benoit Cousson<b-cousson at ti.com>
>
> This patch results in a checkpatch warning:
>
> ---
>
> WARNING: please, no space before tabs
> #23: FILE: arch/arm/mach-omap2/clock44xx_data.c:639:
> +^I.clksel ^I= iva_hsd_byp_clk_mux_sel,$
>
> total: 0 errors, 1 warnings, 0 checks, 13 lines checked
>
> Your patch has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> ---
>
> I've fixed it in the copy in my local branch, but next time, please run
> checkpatch.pl and fix any problems before submitting.

Oops, that's my mistake. the original patch was good, and I messed it up 
during the merge conflict resolution.
And then on top of that I completely missed this warning due to the 
important number of "line over 80 characters" warnings in this series.
I have now a "filter for dummies" to remove that and avoid missing real 
warnings in the future.

Thanks,
Benoit



More information about the linux-arm-kernel mailing list