[PATCH 3/3 v2] dmaengine: Add Freescale i.MX SDMA support

Linus Walleij linus.ml.walleij at gmail.com
Tue Aug 24 11:01:43 EDT 2010


2010/8/24 Lothar Waßmann <LW at karo-electronics.de>:
> [Sacha]
> [...]
>> +static int __devinit sdma_probe(struct platform_device *pdev)
>>
> __devinit/__devexit is for hot-pluggable devices. I don't think the
> SDMA controller is hot-pluggable, so __init/__exit could be used here.

Then the .probe member has to be removed from the
struct platform_driver and platform_driver_probe() used instead
of platform_driver_register().

But it'd work fine I think.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list