[PATCH 08/10] S3C64XX I2S: Return correct codec clock

Mark Brown broonie at opensource.wolfsonmicro.com
Tue Sep 15 07:06:35 EDT 2009


On Tue, Sep 15, 2009 at 07:02:40PM +0900, Jassi wrote:

> -	return i2s->iis_cclk;
> +	if(iismod & S3C64XX_IISMOD_IMS_SYSMUX)
> +		return i2s->iis_cclk;
> +	else
> +		return i2s->iis_pclk;

There's three possible clocks here according to the datasheet - PCLK,
CLKAUDIO and I2SCLK - so this will still give the wrong clock some of
the time.  Also, please use checkpatch.

Ideally we wouldn't have to export the clock at all, of course.



More information about the linux-arm-kernel mailing list