calls to notify_die missing -> ftrace_dump_on_oops non-functional

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Sat Sep 12 15:54:54 EDT 2009


Hello,

I noticed yesterday that ARM doesn't call notify_die (added in

	1eeb66a (move die notifier handling to common code)

).

As ftrace_dump_on_oops depends on this function being called I don't get
an ftrace dump in my oopses.

Locally I added

	notify_die(DIE_OOPS, str, regs, err, current->thread.trap_no, SIGSEGV);

at the end of __die() in arch/arm/kernel/traps.c but I think this is not
completely correct because---assuming I understood it
correctly---notify_die returning NOTIFY_STOP should stop the process
dying.  Christoph, is this correct?

Dying on ARM looks quite different to dying on x86.  Russell, what's
your position here?  Would you accept a patch that makes them more
similar?

Best regards
Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |



More information about the linux-arm-kernel mailing list