[PATCH] net: Fix checks on unsigned in w90p910_ether_probe()

Wan ZongShun mcuos.com at gmail.com
Fri Oct 30 02:18:36 EDT 2009


Dear sirs,

Okay, it is right, thanks all for your help.
I will re-fix it later.

2009/10/30, David Miller <davem at davemloft.net>:
> From: Roel Kluin <roel.kluin at gmail.com>
> Date: Tue, 20 Oct 2009 20:14:36 +0200
>
> > ether->txirq and ->rxirq are unsigned
> >
> > Signed-off-by: Roel Kluin <roel.kluin at gmail.com>
>
> platform_get_irq() returns a signed int so the intention
> is more likely that catching negative value returns
> was intended.
>
> Probably the correct fix is to mark txirq and rxirq as
> plain 'int'.
>


-- 
Wan z.s



More information about the linux-arm-kernel mailing list