[PATCH v2 26/32] OMAP3: PM debug: allow runtime toggle of PM features

[Gopinath, Thara]

>>-----Original Message-----
>>From: linux-omap-owner at vger.kernel.org [mailto:linux-omap-owner at vger.kernel.org] On Behalf Of Kevin
>>Hilman
>>Sent: Friday, October 23, 2009 4:40 AM
>>To: linux-omap at vger.kernel.org
>>Cc: linux-arm-kernel at lists.infradead.org
>>Subject: [PATCH v2 26/32] OMAP3: PM debug: allow runtime toggle of PM features
>>
>>Allow enable/disable of low-power states during idle.  To
>>enable low-power idle:
>>
>>   echo 1 > /debug/pm_debug/sleep_while_idle
>>
>> to disable:
>>
>>   echo 0 > /debug/pm_debug/sleep_while_idle
>>
>>Also allow enable/disable of OFF-mode.  To enable:
>>
>>   echo 1 > /debug/pm_debug/enable_off_mode
>>
>> to disable:
>>
>>   echo 0 > /debug/pm_debug/enable_off_mode
>>
>>Signed-off-by: Kevin Hilman <khilman at deeprootsystems.com>
>>---
>> arch/arm/mach-omap2/pm-debug.c |   27 +++++++++++++++++++++++++++
>> arch/arm/mach-omap2/pm.h       |    4 ++++
>> arch/arm/mach-omap2/pm34xx.c   |   22 ++++++++++++++++++++++
>> arch/arm/mach-omap2/serial.c   |    2 --
>> 4 files changed, 53 insertions(+), 2 deletions(-)
>>
>>diff --git a/arch/arm/mach-omap2/pm-debug.c b/arch/arm/mach-omap2/pm-debug.c
>>index 7eb2c12..1725da3 100644
>>--- a/arch/arm/mach-omap2/pm-debug.c
>>+++ b/arch/arm/mach-omap2/pm-debug.c
>>@@ -527,6 +527,29 @@ static int __init pwrdms_setup(struct powerdomain *pwrdm, void *dir)
>> 	return 0;
>> }
>>
>>+static int option_get(void *data, u64 *val)
>>+{
>>+	u32 *option = data;
>>+
>>+	*val = *option;
>>+
>>+	return 0;
>>+}
>>+
>>+static int option_set(void *data, u64 val)
>>+{
>>+	u32 *option = data;
>>+
>>+	*option = val;
>>+
>>+	if (option == &enable_off_mode)
>>+		omap3_pm_off_mode_enable(val);
>>+
>>+	return 0;
>>+}
>>+
>>+DEFINE_SIMPLE_ATTRIBUTE(pm_dbg_option_fops, option_get, option_set, "%llu\n");
>>+
>> static int __init pm_dbg_init(void)
>> {
>> 	int i;
>>@@ -569,6 +592,10 @@ static int __init pm_dbg_init(void)
>>
>> 		}
>>
>>+	(void) debugfs_create_file("enable_off_mode", S_IRUGO | S_IWUGO, d,
>>+				   &enable_off_mode, &pm_dbg_option_fops);
>>+	(void) debugfs_create_file("sleep_while_idle", S_IRUGO | S_IWUGO, d,
>>+				   &sleep_while_idle, &pm_dbg_option_fops);
>> 	pm_dbg_init_done = 1;
>>
>> 	return 0;
>>diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h
>>index 45cafac..9582793 100644
>>--- a/arch/arm/mach-omap2/pm.h
>>+++ b/arch/arm/mach-omap2/pm.h
>>@@ -13,7 +13,11 @@
>>
>> #include <plat/powerdomain.h>
>>
>>+extern u32 enable_off_mode;
>>+extern u32 sleep_while_idle;
>>+
>> extern void *omap3_secure_ram_storage;
>>+extern void omap3_pm_off_mode_enable(int);
>>
>> extern int omap3_pm_get_suspend_state(struct powerdomain *pwrdm);
>> extern int omap3_pm_set_suspend_state(struct powerdomain *pwrdm, int state);
>>diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
>>index 90d1dc5..ade2e4a 100644
>>--- a/arch/arm/mach-omap2/pm34xx.c
>>+++ b/arch/arm/mach-omap2/pm34xx.c
>>@@ -25,6 +25,7 @@
>> #include <linux/list.h>
>> #include <linux/err.h>
>> #include <linux/gpio.h>
>>+#include <linux/clk.h>
>>
>> #include <plat/sram.h>
>> #include <plat/clockdomain.h>
>>@@ -57,6 +58,9 @@
>> #define OMAP343X_TABLE_VALUE_OFFSET	   0x30
>> #define OMAP343X_CONTROL_REG_VALUE_OFFSET  0x32
>>
>>+u32 enable_off_mode;
>>+u32 sleep_while_idle;
>>+
>> struct power_state {
>> 	struct powerdomain *pwrdm;
>> 	u32 next_state;
>>@@ -456,6 +460,8 @@ static int omap3_fclks_active(void)
>>
>> static int omap3_can_sleep(void)
>> {
>>+	if (!sleep_while_idle)
>>+		return 0;
>> 	if (!omap_uart_can_sleep())
>> 		return 0;
>> 	if (omap3_fclks_active())
>>@@ -900,6 +906,22 @@ static void __init prcm_setup_regs(void)
>> 	omap3_d2d_idle();
>> }
>>
>>+void omap3_pm_off_mode_enable(int enable)
>>+{
>>+	struct power_state *pwrst;
>>+	u32 state;
>>+
>>+	if (enable)
>>+		state = PWRDM_POWER_OFF;
>>+	else
>>+		state = PWRDM_POWER_RET;
>>+
>>+	list_for_each_entry(pwrst, &pwrst_list, node) {
>>+		pwrst->next_state = state;
>>+		set_pwrdm_state(pwrst->pwrdm, state);

Shld the next states of MPU and CORE domain also be changed? It should happen only in idle thread or system suspend path. Not at any arbit point where user sets enable_off_mode.
>>+	}
>>+}
>>+
>> int omap3_pm_get_suspend_state(struct powerdomain *pwrdm)
>> {
>> 	struct power_state *pwrst;
>>diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c
>>index dabc089..2e17b57 100644
>>--- a/arch/arm/mach-omap2/serial.c
>>+++ b/arch/arm/mach-omap2/serial.c
>>@@ -155,8 +155,6 @@ static inline void __init omap_uart_reset(struct omap_uart_state *uart)
>>
>> #if defined(CONFIG_PM) && defined(CONFIG_ARCH_OMAP3)
>>
>>-static int enable_off_mode; /* to be removed by full off-mode patches */
>>-
>> static void omap_uart_save_context(struct omap_uart_state *uart)
>> {
>> 	u16 lcr = 0;
>>--
>>1.6.4.3
>>
>>--
>>To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>>the body of a message to majordomo at vger.kernel.org
>>More majordomo info at  http://vger.kernel.org/majordomo-info.html