[PATCH] arm: Iomega ix4-200d support

[Martin Michlmayr]

* Eric Sandeen <sandeen at redhat.com> [2009-11-13 00:04]:
> +config MACH_IX4_88F6281_NAS
> +	bool "Iomega ix4-200d NAS"

If you look at Kconfig, you'll see that putting the CPU id in the MACH
name is quite unusual for NAS devices (it's only used for dev boards).
I'd make this IX4200D or NASIX400D.

Also, the Kconfig entry should be at the end and not in the middle of
some reference boards.

> --- /dev/null
> +++ b/arch/arm/mach-kirkwood/ix4-88f6281-setup.c

nasix4200d.c or ix4200d.c

> +/*
> + * Marvell RD-88F6281 Reference Board Setup

That's obviously copy&paste...

> + * This file is licensed under the terms of the GNU General Public
> + * License version 2.  This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.

You should add your Copyright.  And probably the Copyright of the file
on which yours is baed.

> +
> +/* #ifdef IX4_BOARD MV_BOARD_INFO db88f6281AInfo db88f6281AInfoBoardMacInfo */

What's that?

> +MACHINE_START(NASIX4200D, "Iomega NAS ix4-200d")
> +	/* Maintainer: Saeed Bishara <saeed at marvell.com> */

That should be you.

> --- a/arch/arm/tools/mach-types
> +++ b/arch/arm/tools/mach-types
> @@ -2132,6 +2132,7 @@ apollo			MACH_APOLLO		APOLLO			2141
> at91cap9stk		MACH_AT91CAP9STK	AT91CAP9STK		2142
> spc300			MACH_SPC300		SPC300			2143
> eko			MACH_EKO		EKO			2144
> +nasix4200d		MACH_IX4_88F6281_NAS	NASIX4200D		2145

That's a big no.  First of all, you have to register your own machine
ID at http://www.arm.linux.org.uk/developer/machines/  Second, when
you submit a patch, don't include mach-types since this is
auto-generated.

Finally, a question: it seems that the buttons and LEDs are not
supported by your patch.  Do you know how they are hooked up?

Thanks for working on this
-- 
Martin Michlmayr
http://www.cyrius.com/