[PATCH 1/3] ezx: Add camera support for A780 and A910 EZX phones

Robert Jarzmik robert.jarzmik at free.fr
Fri Nov 6 12:05:57 EST 2009


Guennadi Liakhovetski <g.liakhovetski at gmx.de> writes:

> Good that you mentioned this. In fact, I think, that .init should go. So 
> far it is used in pcm990-baseboard.c to initialise pins. You're doing 
> essentially the same - requesting and configuring GPIOs. And it has been 
> agreed, that there is so far no real case, where a static 
> GPIO-configuration wouldn't work. So, I would suggest you remove .init, 
> configure GPIOs statically. And then submit a patch to remove .init 
> completely from struct pxacamera_platform_data. Robert, do you agree?

Yes, fully agree, I think too that GPIO should be static.

Cheers.

--
Robert



More information about the linux-arm-kernel mailing list