[PATCH] ARM: pxafb: Use the passed fb_var_screeninfo struct in pxafb_pan_display()

Eric Miao eric.y.miao at gmail.com
Wed Nov 4 09:44:38 EST 2009


> Commit 3a8552e made pxafb pay attention to paramters passed to
> pxafb_pan_display(). As Ville Syrjälä pointed out, this is potentially
> dangerous as user could pass in any other screeninfo parameters as well,
> and not only such that are relevant for display panning.
>
> This patch fixed that by limiting the arguments actually used to
> .xoffset, .yoffset and .vmode & FB_VMODE_YWRAP.
>
> Signed-off-by: Daniel Mack <daniel at caiaq.de>
> Cc: Ville Syrjälä <syrjala at sci.fi>
> Cc: Eric Miao <eric.y.miao at gmail.com>
> Cc: Sven Neumann <s.neumann at raumfeld.com>

OK, merged with the previous commit with additional comments of
the issue found, and with Ville Syrjälä <syrjala at sci.fi> in the Cc
list. Thanks.



More information about the linux-arm-kernel mailing list