[PATCH] pxa: fix system resume issue on pxa27x and pxa3xx

Haojian Zhuang haojian.zhuang at gmail.com
Mon Nov 2 21:19:58 EST 2009


On Mon, Nov 2, 2009 at 1:14 PM, Robert Jarzmik <robert.jarzmik at free.fr> wrote:
> Haojian Zhuang <haojian.zhuang at gmail.com> writes:
>
>> From 1764e836424d42a0654b8b73c402a2dddb118dc4 Mon Sep 17 00:00:00 2001
>> From: Haojian Zhuang <haojian.zhuang at marvell.com>
>> Date: Mon, 2 Nov 2009 14:02:21 -0500
>> Subject: [PATCH] pxa: fix system resume issue on pxa27x and pxa3xx
>>
>> Since interrupt handler is changed to use interrupt priority, we also need to
>> save and restore these interrupt controller registers in suspend/resume
>> routine.
>>
>> Signed-off-by: Haojian Zhuang <haojian.zhuang at marvell.com>
>> Tested-by: Daniel Mack <daniel at caiaq.de>
>
> Yes, the fix does work for my platform too, well done.
> Tested-by: Robert Jarzmik <robert.jarzmik at free.fr>
>
> As a side note, the "128" magic number may have deserved a little define
> somewhere.
>
> Cheers.
>
> --
> Robert
>

Thanks of all good comments. Now I move the check into the
initialization code. If internal irq number is larger than 128, the
larger irqs won't be initialized. So suspend resume routine needn't
access the larger IPR registers. Patch is in below and attached.

Thanks
Haojian


More information about the linux-arm-kernel mailing list