[PATCH 3/7] ARM: S3C64XX: Add I2S resources in platform code

Mark Brown broonie at opensource.wolfsonmicro.com
Sun Dec 13 06:33:28 EST 2009


On 13 Dec 2009, at 09:17, jassi brar <jassisinghbrar at gmail.com> wrote:

> On Wed, Dec 9, 2009 at 7:47 PM, Mark Brown
> <broonie at opensource.wolfsonmicro.com> wrote:
>> On Wed, Dec 09, 2009 at 01:32:03PM +0900, jassisinghbrar at gmail.com  
>> wrote:
>>
>>> +static int s3c64xx_i2sv4_cfg_gpio(struct platform_device *pdev)
>>> +{
>>> +     s3c_gpio_cfgpin(S3C64XX_GPC(4), S3C64XX_GPC4_I2S0_V40_DO);
>>> +     s3c_gpio_cfgpin(S3C64XX_GPC(5), S3C64XX_GPC5_I2S1_V40_DO);
>>> +     s3c_gpio_cfgpin(S3C64XX_GPC(7), S3C64XX_GPC7_I2S2_V40_DO);
>>
>> A variant of this should already have been merged, and the names of  
>> the
>> GPIO defines were altered to make it look less like there's multiple
>> controllers rather than multiple data lines.
> I can see I2S_V4 MACRO renaming but nothing else that this patch does.
> So, i shud resubmit with only new v4-DO MACROs, right?

I'd wait until after -rc1 is out but yes. We'll also need to recheck  
against Ben's reworked clock code.



More information about the linux-arm-kernel mailing list