[PATCH V2 07/09] led: enable led in 88pm860x

Mark Brown broonie at opensource.wolfsonmicro.com
Thu Dec 10 13:04:04 EST 2009


On Wed, Dec 09, 2009 at 10:57:59PM -0500, Haojian Zhuang wrote:

> +	on = *delay_on;
> +	if ((on < LED_BLINK_ON_MIN) || (on > LED_BLINK_ON_MAX))
> +		return -EINVAL;

You're returning -EINVAL here but...

> +	period = on + *delay_off;
> +	if (period < LED_BLINK_PERIOD_MIN)
> +		period = LED_BLINK_PERIOD_MIN;
> +	if (period > LED_BLINK_PERIOD_MAX)
> +		period = LED_BLINK_PERIOD_MAX;

...I'd expect it also here?



More information about the linux-arm-kernel mailing list