[PATCH v2 12/20] rtc: amlogic-a4: Remove IRQF_ONESHOT

Sebastian Andrzej Siewior bigeasy at linutronix.de
Wed Jan 28 01:55:32 PST 2026


Passing IRQF_ONESHOT ensures that the interrupt source is masked until
the secondary (threaded) handler is done. If only a primary handler is
used then the flag makes no sense because the interrupt can not fire
(again) while its handler is running.
The flag also disallows force-threading of the primary handler and the
irq-core will warn about this.

Remove IRQF_ONESHOT from irqflags.

Fixes: c89ac9182ee29 ("rtc: support for the Amlogic on-chip RTC")
Reviewed-by: Xianwei Zhao <xianwei.zhao at amlogic.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy at linutronix.de>
---
Cc: Yiting Deng <yiting.deng at amlogic.com>
Cc: Xianwei Zhao <xianwei.zhao at amlogic.com>
Cc: Alexandre Belloni <alexandre.belloni at bootlin.com>
Cc: linux-amlogic at lists.infradead.org
Cc: linux-rtc at vger.kernel.org
---
 drivers/rtc/rtc-amlogic-a4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-amlogic-a4.c b/drivers/rtc/rtc-amlogic-a4.c
index 123fb372fc9fe..50938c35af36a 100644
--- a/drivers/rtc/rtc-amlogic-a4.c
+++ b/drivers/rtc/rtc-amlogic-a4.c
@@ -369,7 +369,7 @@ static int aml_rtc_probe(struct platform_device *pdev)
 		return PTR_ERR(rtc->rtc_dev);
 
 	ret = devm_request_irq(dev, rtc->irq, aml_rtc_handler,
-			       IRQF_ONESHOT, "aml-rtc alarm", rtc);
+			       0, "aml-rtc alarm", rtc);
 	if (ret) {
 		dev_err_probe(dev, ret, "IRQ%d request failed, ret = %d\n",
 			      rtc->irq, ret);
-- 
2.51.0




More information about the linux-amlogic mailing list