[PATCH 0/1] Meson8b RGMII Ethernet pin cleanup

Martin Blumenstingl martin.blumenstingl at googlemail.com
Fri May 4 13:09:37 PDT 2018


Hi Emiliano,

On Thu, May 3, 2018 at 7:06 PM, Emiliano Ingrassia
<ingrassia at epigenesys.com> wrote:
> Hi Martin,
>
> the patch seems to work fine but I have two questions.
thank you for testing this! :)

> First, should we remove those pins from "ethernet_groups" structure
> in "drivers/pinctrl/meson/pinctrl-meson8b.c" ?
I believe that some boards with RMII (100Mbit/s) PHY use TXD0/TXD1 on
DIF_2_P and DIF_2_N
so we should keep support for these in the driver

> Second, following the Odroid-C1+ schematics there are two pins,
> "eth_rxd2" and "eth_rxd3" which are not configured by the pin controller
> driver, nor included in the pins group in the relative device tree.
> Should we configure and include them ?
interesting - good catch. I think we should include them in both, the
pinctrl driver and meson8b.dtsi
do you know which pads are used for "eth_rxd2" and "eth_rxd3"?


Regards
Martin



More information about the linux-amlogic mailing list