[PATCH v4 04/10] i2c: meson: use i2c core for DT clock-frequency parsing

Neil Armstrong narmstrong at baylibre.com
Fri Mar 24 03:19:21 PDT 2017


On 03/24/2017 07:47 AM, Heiner Kallweit wrote:
> Am 23.03.2017 um 21:33 schrieb Wolfram Sang:
>>
>>> +- i2c-scl-falling-time-ns
>>> +  Number of nanoseconds the SCL signal takes to fall; t(f) in the I2C
>>> +  specification.
>>> +
>>> +- i2c-scl-internal-delay-ns
>>> +  Number of nanoseconds the IP core additionally needs to setup SCL.
>>> +
>>> +- i2c-scl-rising-time-ns
>>> +  Number of nanoseconds the SCL signal takes to rise; t(r) in the I2C
>>> +  specification.
>>> +
>>> +- i2c-sda-falling-time-ns
>>> +  Number of nanoseconds the SDA signal takes to fall; t(f) in the I2C
>>> +  specification.
>>
>> Those are not used currently. Can the driver be updated to make use of
>> them? Otherwise, we might just skip this section.
>>
> Adding these properties was outcome of a discussion with Amlogic
> maintainers. It's right that they aren't used by the driver and the
> chip also provides no means to change the related timings.
> So I will remove this part.
> 

Hi Heiner,

Indeed, these are not needed for Amlogic platform, you should remove them.
I missed them in my review.

Neil




More information about the linux-amlogic mailing list