[PATCH 1/5] clk: meson: Add support for parameters for specific PLLs

Neil Armstrong narmstrong at baylibre.com
Wed Mar 22 03:23:24 PDT 2017


On 03/22/2017 12:43 AM, Michael Turquette wrote:
> Quoting Neil Armstrong (2017-03-13 06:26:40)
[..]
>>  
>>         p = &pll->n;
>> -       ret = meson_clk_pll_wait_lock(pll, p);
>> +       /* If unreset_for_lock is provided, remove the reset bit here */
>> +       if (pll->params.unreset_for_lock) {
> 
> Small nitpick, but I find "unreset" to be confusing. Since 'reset' here
> is a bit that can be set and unset, maybe use clear_reset_for_lock
> instead?
> 
> Regards,
> Mike
> 

You are right, I'll rename it.

Neil




More information about the linux-amlogic mailing list