[PATCH v2 6/6] serial: meson: change interrupt description to tty name

Yixun Lan dlan at gentoo.org
Wed Apr 26 23:13:07 PDT 2017


On 22:18 Wed 19 Apr     , Heiner Kallweit wrote:
> Change interrupt description from driver name to tty name
> (e.g. ttyAML0). If multiple serial ports are enabled this
> allows to determine which interrupt belongs to which port
> in /proc/interrupts.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1 at gmail.com>
> ---
> v2:
> - use new port->name instead of of node name
> ---
>  drivers/tty/serial/meson_uart.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
> index 171eb673..082e038e 100644
> --- a/drivers/tty/serial/meson_uart.c
> +++ b/drivers/tty/serial/meson_uart.c
> @@ -295,7 +295,7 @@ static int meson_uart_startup(struct uart_port *port)
>  	writel(val, port->membase + AML_UART_MISC);
>  
>  	ret = request_irq(port->irq, meson_uart_interrupt, 0,
> -			  meson_uart_type(port), port);
> +			  port->name, port);
>  
>  	return ret;
>  }
> -- 
> 2.12.2
> 
> 
> 
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic

Hi Heiner Kallweit:

there is no member of 'name' in 'struct uart_port'
or did I miss something obviously?
(btw, I'm applying these patches on top of khilman's tree: branch v4.12/integ)

as I got this error:

drivers/tty/serial/meson_uart.c: In function ‘meson_uart_startup’:                
drivers/tty/serial/meson_uart.c:298:10: error: ‘struct uart_port’ has no
member named ‘name’
      port->name, port);                         
          ^~                                                              
make[3]: *** [scripts/Makefile.build:294: drivers/tty/serial/meson_uart.o] Error 1
make[3]: *** Waiting for unfinished jobs....  

-- 
Yixun Lan (dlan)
Gentoo Linux Developer
GPG Key ID AABEFD55



More information about the linux-amlogic mailing list