[PATCH] cachefiles: Fix excess dput() after end_removing()

Marc Dionne marc.dionne at auristor.com
Wed Mar 25 04:06:20 PDT 2026


On Tue, Mar 24, 2026 at 7:50 PM David Howells <dhowells at redhat.com> wrote:
>
> David Howells <dhowells at redhat.com> wrote:
>
> > Fixes: 7bb1eb45e43c ("VFS: introduce start_removing_dentry()")
>
> Actually, this should probably be:
>
> Fixes: bd6ede8a06e8 ("VFS/nfsd/cachefiles/ovl: introduce start_removing() and end_removing()")

I think 7bb1eb45e43c is correct.  As of bd6ede8a06e8 the pattern was:

cachefiles_cull
  cachefiles_lookup_for_cull
    start_removing
  cachefiles_bury_object
    dget
    end_removing
  dput

where the dput paired up with the extra dget in cachefiles_bury_object.
After 7bb1eb45e43c it became:

cachefiles_cull
  cachefiles_lookup_for_cull
    start_removing
  cachefiles_bury_object
    end_removing
  dput

Marc



More information about the linux-afs mailing list