[PATCH] rxrpc: Fix data-race warning and potential load/store tearing

[kernel test robot]

Hi David,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net/main]
[also build test WARNING on net-next/main linus/master v6.19-rc5 next-20260113]
[cannot apply to horms-ipvs/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/David-Howells/rxrpc-Fix-data-race-warning-and-potential-load-store-tearing/20260114-005726
base:   net/main
patch link:    https://lore.kernel.org/r/3535584.1768322992%40warthog.procyon.org.uk
patch subject: [PATCH] rxrpc: Fix data-race warning and potential load/store tearing
config: x86_64-rhel-9.4-ltp (https://download.01.org/0day-ci/archive/20260114/202601141005.joqBs0CU-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260114/202601141005.joqBs0CU-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601141005.joqBs0CU-lkp@intel.com/

All warnings (new ones prefixed by >>):

   net/rxrpc/proc.c: In function 'rxrpc_peer_seq_show':
>> net/rxrpc/proc.c:299:61: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 8 has type 'int' [-Wformat=]
     299 |                    "UDP   %-47.47s %-47.47s %3u %4u %5u %6llus %8d %8d\n",
         |                                                         ~~~~^
         |                                                             |
         |                                                             long long unsigned int
         |                                                         %6u
   ......
     305 |                    (s32)now - (s32)peer->last_tx_at,
         |                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~          
         |                             |
         |                             int


vim +299 net/rxrpc/proc.c

d2ce4a84c21f803 David Howells 2023-10-26  274  
bc0e7cf43370a8e David Howells 2018-10-15  275  /*
bc0e7cf43370a8e David Howells 2018-10-15  276   * generate a list of extant virtual peers in /proc/net/rxrpc/peers
bc0e7cf43370a8e David Howells 2018-10-15  277   */
bc0e7cf43370a8e David Howells 2018-10-15  278  static int rxrpc_peer_seq_show(struct seq_file *seq, void *v)
bc0e7cf43370a8e David Howells 2018-10-15  279  {
bc0e7cf43370a8e David Howells 2018-10-15  280  	struct rxrpc_peer *peer;
bc0e7cf43370a8e David Howells 2018-10-15  281  	time64_t now;
bc0e7cf43370a8e David Howells 2018-10-15  282  	char lbuff[50], rbuff[50];
bc0e7cf43370a8e David Howells 2018-10-15  283  
bc0e7cf43370a8e David Howells 2018-10-15  284  	if (v == SEQ_START_TOKEN) {
bc0e7cf43370a8e David Howells 2018-10-15  285  		seq_puts(seq,
eeaedc5449d9fcc David Howells 2024-12-04  286  			 "Proto Local                                           Remote                                          Use SST   Maxd LastUse      RTT      RTO\n"
bc0e7cf43370a8e David Howells 2018-10-15  287  			 );
bc0e7cf43370a8e David Howells 2018-10-15  288  		return 0;
bc0e7cf43370a8e David Howells 2018-10-15  289  	}
bc0e7cf43370a8e David Howells 2018-10-15  290  
bc0e7cf43370a8e David Howells 2018-10-15  291  	peer = list_entry(v, struct rxrpc_peer, hash_link);
bc0e7cf43370a8e David Howells 2018-10-15  292  
bc0e7cf43370a8e David Howells 2018-10-15  293  	sprintf(lbuff, "%pISpc", &peer->local->srx.transport);
bc0e7cf43370a8e David Howells 2018-10-15  294  
bc0e7cf43370a8e David Howells 2018-10-15  295  	sprintf(rbuff, "%pISpc", &peer->srx.transport);
bc0e7cf43370a8e David Howells 2018-10-15  296  
bc0e7cf43370a8e David Howells 2018-10-15  297  	now = ktime_get_seconds();
bc0e7cf43370a8e David Howells 2018-10-15  298  	seq_printf(seq,
b40ef2b85a7d117 David Howells 2024-12-04 @299  		   "UDP   %-47.47s %-47.47s %3u %4u %5u %6llus %8d %8d\n",
bc0e7cf43370a8e David Howells 2018-10-15  300  		   lbuff,
bc0e7cf43370a8e David Howells 2018-10-15  301  		   rbuff,
a05754295e01f00 David Howells 2022-05-21  302  		   refcount_read(&peer->ref),
1fc4fa2ac93dcf3 David Howells 2022-10-03  303  		   peer->cong_ssthresh,
eeaedc5449d9fcc David Howells 2024-12-04  304  		   peer->max_data,
db6f1fa7f67e415 David Howells 2026-01-13  305  		   (s32)now - (s32)peer->last_tx_at,
b40ef2b85a7d117 David Howells 2024-12-04  306  		   READ_ONCE(peer->recent_srtt_us),
b40ef2b85a7d117 David Howells 2024-12-04  307  		   READ_ONCE(peer->recent_rto_us));
bc0e7cf43370a8e David Howells 2018-10-15  308  
bc0e7cf43370a8e David Howells 2018-10-15  309  	return 0;
bc0e7cf43370a8e David Howells 2018-10-15  310  }
bc0e7cf43370a8e David Howells 2018-10-15  311  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki