[bug report] rxrpc: Allow CHALLENGEs to the passed to the app for a RESPONSE

[David Howells]

Dan Carpenter <dan.carpenter at linaro.org> wrote:

> Commit 5800b1cf3fd8 ("rxrpc: Allow CHALLENGEs to the passed to the
> app for a RESPONSE") from Apr 11, 2025 (linux-next), leads to the
> following Smatch static checker warning:
> 
> 	net/rxrpc/insecure.c:48 none_validate_challenge()
> 	warn: signedness bug returning '(-71)'
> 
> net/rxrpc/insecure.c
>     45 static bool none_validate_challenge(struct rxrpc_connection *conn,
>     46                                     struct sk_buff *skb)
>     47 {
> --> 48         return rxrpc_abort_conn(conn, skb, RX_PROTOCOL_ERROR, -EPROTO,
> 
> This is reversed.  It's returning true for failure instead of false.

This was fixed by fd579a2ebbe4b7e6b388915a50d904e772a35c61.

David