[PATCH 03/11] afs: Fix a use after free in afs_xattr_get_acl()
David Howells
dhowells at redhat.com
Wed Oct 28 18:22:57 EDT 2020
From: Dan Carpenter <dan.carpenter at oracle.com>
The "op" pointer is freed earlier when we call afs_put_operation().
Fixes: e49c7b2f6de7 ("afs: Build an abstraction around an "operation" concept")
Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
Signed-off-by: David Howells <dhowells at redhat.com>
cc: Colin Ian King <colin.king at canonical.com>
---
fs/afs/xattr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/afs/xattr.c b/fs/afs/xattr.c
index 84f3c4f57531..38884d6c57cd 100644
--- a/fs/afs/xattr.c
+++ b/fs/afs/xattr.c
@@ -85,7 +85,7 @@ static int afs_xattr_get_acl(const struct xattr_handler *handler,
if (acl->size <= size)
memcpy(buffer, acl->data, acl->size);
else
- op->error = -ERANGE;
+ ret = -ERANGE;
}
}
More information about the linux-afs
mailing list