[PATCH] afs: Fix key ref leak in afs_put_operation()

David Howells dhowells at redhat.com
Tue Aug 18 08:26:28 EDT 2020


The afs_put_operation() function needs to put the reference to the key
that's covering the operation.

Fixes: e49c7b2f6de7 ("afs: Build an abstraction around an "operation" concept")
Reported-by: Dave Botsch <botsch at cnf.cornell.edu>
Signed-off-by: David Howells <dhowells at redhat.com>
---

 fs/afs/fs_operation.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/afs/fs_operation.c b/fs/afs/fs_operation.c
index 24fd163c6323..97cab12b0a6c 100644
--- a/fs/afs/fs_operation.c
+++ b/fs/afs/fs_operation.c
@@ -235,6 +235,7 @@ int afs_put_operation(struct afs_operation *op)
 	afs_end_cursor(&op->ac);
 	afs_put_serverlist(op->net, op->server_list);
 	afs_put_volume(op->net, op->volume, afs_volume_trace_put_put_op);
+	key_put(op->key);
 	kfree(op);
 	return ret;
 }





More information about the linux-afs mailing list