[PATCH 19/35] f2fs: Simplify page iteration loops

[kbuild test robot]

Hi Jan,

[auto build test WARNING on linus/master]
[also build test WARNING on v4.12-rc3]
[cannot apply to next-20170601]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Jan-Kara/pagevec-API-cleanups/20170601-200653
config: x86_64-randconfig-x019-201722 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   fs//f2fs/checkpoint.c: In function 'sync_meta_pages':
>> fs//f2fs/checkpoint.c:313:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
        PAGECACHE_TAG_DIRTY, PAGEVEC_SIZE)) {
        ^~~~~~~~~~~~~~~~~~~
--
   fs//f2fs/node.c: In function 'last_fsync_dnode':
>> fs//f2fs/node.c:1271:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
        PAGECACHE_TAG_DIRTY, PAGEVEC_SIZE)) {
        ^~~~~~~~~~~~~~~~~~~
   fs//f2fs/node.c: In function 'fsync_node_pages':
   fs//f2fs/node.c:1421:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
        PAGECACHE_TAG_DIRTY, PAGEVEC_SIZE)) {
        ^~~~~~~~~~~~~~~~~~~
   fs//f2fs/node.c: In function 'sync_node_pages':
   fs//f2fs/node.c:1533:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
        PAGECACHE_TAG_DIRTY, PAGEVEC_SIZE)) {
        ^~~~~~~~~~~~~~~~~~~
   fs//f2fs/node.c: In function 'wait_on_node_pages_writeback':
   fs//f2fs/node.c:1630:5: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
        PAGECACHE_TAG_WRITEBACK, PAGEVEC_SIZE)) {
        ^~~~~~~~~~~~~~~~~~~~~~~

vim +313 fs//f2fs/checkpoint.c

   297	{
   298		struct address_space *mapping = META_MAPPING(sbi);
   299		pgoff_t index = 0, prev = ULONG_MAX;
   300		struct pagevec pvec;
   301		long nwritten = 0;
   302		int nr_pages;
   303		struct writeback_control wbc = {
   304			.for_reclaim = 0,
   305		};
   306		struct blk_plug plug;
   307	
   308		pagevec_init(&pvec, 0);
   309	
   310		blk_start_plug(&plug);
   311	
   312		while (nr_pages = pagevec_lookup_tag(&pvec, mapping, &index,
 > 313					PAGECACHE_TAG_DIRTY, PAGEVEC_SIZE)) {
   314			int i;
   315	
   316			for (i = 0; i < nr_pages; i++) {
   317				struct page *page = pvec.pages[i];
   318	
   319				if (prev == ULONG_MAX)
   320					prev = page->index - 1;
   321				if (nr_to_write != LONG_MAX && page->index != prev + 1) {

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 23456 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-afs/attachments/20170601/1eb0b191/attachment-0001.gz>