Can the channel ID be ignored? [Was Re: af_rxrpc: RXRPC reorganisation]

[Tim Smith]

On Wednesday 28 May 2014 11:56:54 David Howells wrote:
> Tim Smith <tim at electronghost.co.uk> wrote:
> > struct rxrpc_call seems to contain a lot of stuff which is per-channel
> 
> You might also just ignore the channel ID field entirely - except to check
> that it's correct for any particular call.  We don't really care if we get
> more than four calls for a connection: the "four channels" thing is there to
> speed up call lookup - but does it really help with your hashing stuff in
> place in the kernel?

You mean just accept the new call anyway? That could be trouble.

Sending a BUSY when we are in fact busy protects the client's state machine, 
which may reasonably rely on getting that BUSY if its final ACK was eaten by 
Cthulu in the network somewhere.


-- 
Tim Smith <tim at electronghost.co.uk>
Romantic longing leads to an inefficient appliance.
    -- Gunnerkrigg Court Student's Handbook, Chapter 113, Section H
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-afs/attachments/20140528/79f9d91d/attachment.sig>