[PATCH] af_rxrpc accept race (was: RxRPC: 3 issues found in my example code)

[Tim Smith]

On Monday 12 May 2014 13:50:13 David Howells wrote:
> Tim Smith <tim at electronghost.co.uk> wrote:
> > -			skb_queue_tail(&local->accept_queue, skb);
> > -			rxrpc_queue_work(&local->acceptor);
> > +			rxrpc_accept_incoming_call(local, skb);
> 
> The main problem I have with this is that you're putting a lot of work into
> the UDP driver's sk_data_ready callback.  Some of that work involves memory
> allocation with GFP_NOIO or GFP_NOFS - which may not be appropriate for the
> context.

In which case going the other way will be necessary and sending the subsequent 
packets through the work queue. Well, that or adding a lock back in.

I will try the former.


-- 
Tim Smith <tim at electronghost.co.uk>
17% of Wookiees above the age of three hundred wear hairpieces.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-afs/attachments/20140512/3637873e/attachment.sig>