Dan Carpenter <error27 at gmail.com> wrote: > I was concerned about the dereference here: > > + if (xpermits) > + memcpy(permits->permits, xpermits->permits, > ^^^^^^^^^^^^^^^^^ > + count * sizeof(struct afs_permit)); That's a good point - in which case your patch should definitely go in. David