[PATCH main v3 2/2] macsec: Fix set offload capability for MACsec

[Thomas Haller]

Hi,


On Mon, 2023-02-27 at 07:48 +0000, Emeel Hakim wrote:
> A kind ping for this patch.
> Am I missing something?

no, you did everything right.
Sorry for not replying for so long!

As conclusion, the patchset moved to
https://github.com/thom311/libnl/pull/341


Thank you,
Thomas



> 
> > -----Original Message-----
> > From: Emeel Hakim <ehakim at nvidia.com>
> > Sent: Wednesday, 15 February 2023 10:13
> > To: libnl at lists.infradead.org
> > Cc: sd at queasysnail.net; Emeel Hakim <ehakim at nvidia.com>
> > Subject: [PATCH main v3 2/2] macsec: Fix set offload capability for
> > MACsec
> > 
> > Currently, rtnl_link_macsec_set_offload rejects any value greater
> > than 1 limiting
> > the MACSEC_ATTR_OFFLOAD attribute to the values 0 and 1 where 2 is
> > also a legal
> > value.
> > Fix by allowing all legal values for MACSEC_ATTR_OFFLOAD.
> > 
> > Fixes: b6cc13d76b29 ("Supporting Hardware offload capability for
> > MACsec")
> > Signed-off-by: Emeel Hakim <ehakim at nvidia.com>
> > ---
> > V1 -> V2: Use MACSEC_OFFLOAD_ATTR_MAX
> > V2 -> V3: Use MACSEC_OFFLOAD_MAX instead of MACSEC_OFFLOAD_ATTR_MAX
> > since it is the right field to use.
> > 
> >  lib/route/link/macsec.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/lib/route/link/macsec.c b/lib/route/link/macsec.c
> > index
> > 16b65b0..9bc8f7b 100644
> > --- a/lib/route/link/macsec.c
> > +++ b/lib/route/link/macsec.c
> > @@ -652,7 +652,7 @@ int rtnl_link_macsec_set_offload(struct
> > rtnl_link *link,
> > uint8_t offload)
> > 
> >         IS_MACSEC_LINK_ASSERT(link);
> > 
> > -       if (offload > 1)
> > +       if (offload > MACSEC_OFFLOAD_MAX)
> >                 return -NLE_INVAL;
> > 
> >         info->offload = offload;
> > --
> > 2.21.3
> 
> _______________________________________________
> libnl mailing list
> libnl at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/libnl
>