[PATCH] lib/route: Export correct ipgre functionality

[Thomas Haller]

On Sat, 2016-11-05 at 18:47 +0000, Oliver, Jef wrote:
> On Nov 5, 2016 10:18 AM, Thomas Haller <thaller at redhat.com> wrote:
> >
> > On Wed, 2016-10-05 at 13:20 -0700, Jef Oliver wrote:
> > > * Rename rtnl_link_get_pmtudisc to rtnl_link_ipgre_get_pmtudisc
> > >   in ipgre.c, making the function correctly match the exported
> > >   functionality in ipgre.h. This fixes an error when trying to
> > >   use the function, returning an incorrect type usage due to the
> > >   link module already having a function of the same name.
> > > 
> > > * Export rtnl_link_is_[ipgre/ipgretap] allowing for usage per
> > >   documentation.
> > > 
> >
> > Hi Jef,
> >
> >
> > merged as https://github.com/thom311/libnl/commit/d752558bc23430c6c
> 536046ae44b93fd0b099f6c
> >
> >
> > I didn't like changing ABI, thus I re-added the wrong name (without
> > public API).
> >
> Will this cause problems as rtnl_link_get_pmtudisc is export as int
> and uint8_t? It is an int in link.h and uint8_t in ipgre.h. This was
> causing problems when using the function as type mismatches.
> Jef

Hi Jef,

sorry, I don't follow. rtnl_link_get_pmtudisc is exported as symbol in
the ABI, but it is not part of public API (in a C header file). No
problem is there, isn't it?

Probably I just don't understand what you mean.

Thomas 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/libnl/attachments/20161105/dae8ea97/attachment.sig>