[PATCH 0/3] xfrm: Fixes for xfrm part of libnl

Thomas Egerer thomas.egerer at secunet.com
Mon Jun 27 10:10:30 PDT 2016


Hello Thomas,

On 06/25/2016 05:38 PM, Thomas Haller wrote:
> On Fri, 2016-06-10 at 11:57 +0200, Thomas Egerer wrote:
>> Hi *,
>>
>> here's a series of patches for the xfrm part of libxml. Amongst a
>> fix of a segfault when dealing with encapsulation templates, it
>> removes a memory leak and optimizes the netlink message construction
>> in a way that only either xfrm_algo or xfrm_algo_auth is sent.
>> I would be thrilled to get some feedback on these and my previous
>> patches.
>>
>> Cheers,
>> Thomas
> 
> 
> Hi Thomas,
> 
> I merged your three patches:
> https://github.com/thom311/libnl/commit/a24319393ced15d611645fec6004284d96c042cd
> 
> Thanks for sending them.
> 
> 
> I included two additional patches, do they look good to you?
You're right, commit 6db1547 introduced a memory leak.
And your reuse of the encap templ in commit 0ee916b avoids
a free and immediate calloc. Looks fine to me.
> 
> 
> Thomas
> 
Thanks for applying.

Thomas



More information about the libnl mailing list