[PATCH 1/1] idiag: fix set of identifying properties for idiag_msg_obj
Thomas Haller
thaller at redhat.com
Thu Nov 27 08:13:29 PST 2014
On Thu, 2014-11-27 at 07:14 -0800, Cong Wang wrote:
> On Wed, Nov 26, 2014 at 3:34 AM, Thomas Haller <thaller at redhat.com> wrote:
> > Hi Cong,
> >
>
> Hi,
>
> > how about this now? I actually don't know which fields constitute
> > the identifying properties. I think having state there is wrong.
> >
>
> I agree.
>
> > Can you verify that now it is correct? Note that for this to be correct,
> > these 5 properties must always be present in every (valid) idiag_msg_obj
> > and they must never change -- for the same instance.
> >
>
> I can't test it now, because I am on vacation. But it looks good
> to my eyes. :)
>
> Thanks for the patch!
merged patch as:
https://github.com/thom311/libnl/commit/3a8d6cfd5616df2122e116c12dc865b16ee97d5e
thanks for testing -- after vacation!! :)
Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/libnl/attachments/20141127/a0a9f0ee/attachment.sig>
More information about the libnl
mailing list