[PATCH 04/13] idiag: deprecate IDIAG_ATTR_* enumeration

Thomas Graf tgraf at suug.ch
Mon Nov 24 09:12:22 PST 2014


On 11/24/14 at 05:14pm, Thomas Haller wrote:
> IDIAG_ATTR_* were a copy of the INET_DIAG_* extension kernel
> flags. Redefining them is wrong, user space should continue
> to use the values provided via the kernel headers.
> 
> Also they were misused as change flags (ce_mask), which they are not.
> 
> Deprecate the IDIAG_ATTR_* flags and redefine them to what the
> originally are: INET_DIAG_*.
> 
> Also deprecated idiagnl_attrs2str() because there is already
> idiagnl_exts2str(). idiagnl_attrs2str() in the sense of libnl change
> flags (ce_mask) makes no sense.
> 
> Signed-off-by: Thomas Haller <thaller at redhat.com>

Acked-by: Thomas Graf <tgraf at suug.ch>



More information about the libnl mailing list