[PATCH 1/5] route: don't enforce minlen in inet6_parse_protinfo() (IFLA_PROTINFO) and inet_parse_af() (IFLA_AF_SPEC)

Thomas Graf tgraf at suug.ch
Thu Mar 20 18:26:48 EDT 2014


On 03/20/14 at 07:18pm, Thomas Haller wrote:
> Older kernel version might have fewer values defined, so they would send
> netlink messages that got rejected. Only check that at least one value
> got sent.
> 
> This is especially grave as libnl uses an internal copy of the
> kernel header files. Thus not only it is bound to the installed kernel
> headers but to the libnl internal header copies that might easily be out
> of sync with the kernel.
> 
> This affects IFLA_PROTINFO, inet6_parse_protinfo():
>   - tb[IFLA_INET6_CONF], expecting DEVCONF_MAX
>   - tb[IFLA_INET6_STATS], expecting __IPSTATS_MIB_MAX
>   - tb[IFLA_INET6_ICMP6STATS], expecting __ICMP6_MIB_MAX
> and IFLA_AF_SPEC, inet_parse_af():
>   - tb[IFLA_INET_CONF], expecting IPV4_DEVCONF_MAX
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1062533
> 
> Signed-off-by: Thomas Haller <thaller at redhat.com>

Acked-by: Thomas Graf <tgraf at suug.ch>



More information about the libnl mailing list