[PATCH 0/3] Headers fix plus other minor fixes

[Peter Wu]

On Wednesday 25 June 2014 10:08:42 Thomas Haller wrote:
> On Tue, 2014-06-24 at 23:13 +0200, Peter Wu wrote:
> > Hi,
> > 
> > While building Wireshark with clang, I noticed a defect in the attr.h header
> > which breaks a -Werror build. While fixing that, I noticed two other minor
> > defects which were caught by Clang static analyzer.
> > 
> > Please have a look at them.
> 
> 
> Hello Peter,
> 
> 
> these 3 fixes seem very reasonable to me.
> 
> I merged them as
> https://github.com/thom311/libnl/commit/baaf82d6d6e023d422809b16865bda2e39c589b5

Thanks! Nitpick: I used scan-build (from Clang), not Coverity. End result is
probably the same, but I can really recommend to use this free tool to find
bugs. You can read more about it on http://clang-analyzer.llvm.org/

There were more reports, four from use-after-free (false positive, there is
a debug print for a pointer that was just freed), some dead assignments
and other details that may need some annotation.

Could you also update the git and HTTP URLs on
http://www.infradead.org/~tgr/libnl/? You seem to have changed the username.
The infradead git repo seems also to be out of sync (that's where I based
my patches on).

Kind regards,
Peter